Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using nmt.DefaultNamespaceIDLen #1384

Closed
rootulp opened this issue Feb 15, 2023 · 1 comment · Fixed by #1385
Closed

Stop using nmt.DefaultNamespaceIDLen #1384

rootulp opened this issue Feb 15, 2023 · 1 comment · Fixed by #1385
Assignees
@rootulp
Labels
chore optional label for items that follow the `chore` conventional commit

Comments

@rootulp
Copy link
Collaborator

rootulp commented Feb 15, 2023

imo yes, and we should probably not rely on that like we do now, simply for the sake of being explicit. so each time we create an nmt, we should use the option as if the default was wrong.

Originally posted by @evan-forbes in #1382 (comment)
@rootulp rootulp self-assigned this Feb 15, 2023
@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Feb 15, 2023
@rootulp rootulp changed the title Stop using nmt.DefaultNamespaceIDLen Stop using `nmt.DefaultNamespaceIDLen Feb 15, 2023
@rootulp rootulp changed the title Stop using `nmt.DefaultNamespaceIDLen Stop using nmt.DefaultNamespaceIDLen Feb 15, 2023
@rootulp
Copy link
Collaborator Author

rootulp commented Feb 15, 2023

The motivation behind this issue is that we're considering changing the namespace ID size (see #1308). It isn't strictly necessary to change the DefaultNamespaceIDLen constant in https://github.com/celestiaorg/nmt/ in order to make this change.

This was referenced Feb 15, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: explicitly set namespace size rootulp/celestia-app
1 participant
@rootulp