Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchange and Subscriber should call Validate on incoming headers #78

Closed
Wondertan opened this issue Jul 10, 2023 · 0 comments · Fixed by #89
Closed

Exchange and Subscriber should call Validate on incoming headers #78

Wondertan opened this issue Jul 10, 2023 · 0 comments · Fixed by #89

Comments

@Wondertan
Copy link
Member

In celestia-node we do Validate inside Unmarshal, which means the library trusts the implementor to do it. Instead, the library should do it.
@Wondertan Wondertan mentioned this issue Jul 29, 2023
Merged
Wondertan added a commit that referenced this issue Aug 21, 2023
@Wondertan
fix: ensure header.Validate is called by the lib (#89)
6069d6a 
Header implementations should not call Validate themselves as the lib now controls it.

Additionally, we unify the response processing code and Header constructor.

Contains error checks corrections

Closes #78
Based on #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure header.Validate is called by the lib celestiaorg/go-header
1 participant
@Wondertan