fix(sync): Fix total_synced metric recording
#124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
tzdybal,
Wondertan,
vgonkivs and
gupadhyaya
as code owners
renaynay
changed the title
total_synced metric recording
Codecov Report
@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 69.20% 69.27% +0.06%
==========================================
Files 37 37
Lines 2981 2981
==========================================
+ Hits 2063 2065 +2
+ Misses 771 769 -2
Partials 147 147
|
vgonkivs
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
total_syncedmetric such that it actually updates the total amount of synced headers rather than overriding the value every time (missed this during code review of #121)