Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: Change stream-reset related errors' level from ERROR to WARN. #161

Merged
merged 1 commit into from
Mar 7, 2024
Merged

log: Change stream-reset related errors' level from ERROR to WARN. #161

merged 1 commit into from
Mar 7, 2024

Conversation

AryanGodara
Copy link
Contributor

@AryanGodara AryanGodara commented Mar 3, 2024 •
edited
Loading

Overview

Resolves: #140

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@AryanGodara
Copy link
Contributor Author

@Wondertan These were the cases I could find where the log level for stream change was ERROR, I checked, and these were the ones mentioned in the original issue as well.

Wondertan
Wondertan approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@renaynay renaynay merged commit 0b32df0 into celestiaorg:main Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay renaynay approved these changes

@tzdybal tzdybal Awaiting requested review from tzdybal tzdybal is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya gupadhyaya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log: Change stream reset-related errors from ERROR to WARN level
3 participants
@AryanGodara @Wondertan @renaynay