Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'this._transport._transport' of undefined #74

Closed
dragnet opened this issue Jan 31, 2019 · 2 comments
Closed

Cannot read property 'this._transport._transport' of undefined #74

dragnet opened this issue Jan 31, 2019 · 2 comments

Comments

@dragnet
Copy link

dragnet commented Jan 31, 2019

You have a mistake in conditions:

const transportOpen = this._transport &&
      this._transport._transport &&
      this._transport._transport.readyState === this._transport._transport.OPEN;

this._transport._transport of undefined

Need change to:

const transportOpen = this._transport && this._transport.readyState === this._transport.OPEN;
@FZambia
Copy link
Member

FZambia commented Jan 31, 2019

@dragnet thanks a lot!

The reason is in difference between SockJS and Websocket - I've tested changes using only SockJS transport. Will try to add more tests in future but just don't have enough time for this :(

I believe that the problem should be fixed by 4102f04, already released 2.1.1 with this change. Could you try it and check that it works properly for you now?

@dragnet
Copy link
Author

dragnet commented Feb 1, 2019

yes, it works correct for now, thanks, Alexander, you reacted very quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants