Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rt-Api pallet-loans - Unify External- and Internal-Pricing #1675

Open
mustermeiszer opened this issue Jan 8, 2024 · 0 comments
Open
Labels
I6-refactoring Code needs refactoring.

Comments

@mustermeiszer
Copy link
Collaborator

Description

We are planning on merging the currently existing Pricing::External and Pricing::Internal methods into a single pricing mechanism to unify the loans logic and allow to price all assets in both ways.

See specification here.

The problem is that from an indexing perspective this is a breaking change, so it would be desirable if the existing runtime api LoansApi would already fake this unification on the api level so that the indexer simply can use this api.

Research/based on

Communication with @hieronx and Embrio.

How will this affect the code base

Allow indexers to handle all blocks the same w.r.t loans and not have custom logic pre- and post-changes.

What are foreseen obstacles or hurdles to overcome?

  • Lock in of datastructure on the api level which could be a real problem in the future.
@mustermeiszer mustermeiszer added the I6-refactoring Code needs refactoring. label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I6-refactoring Code needs refactoring.
Projects
None yet
Development

No branches or pull requests

1 participant