Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OrderBook: Runtime API to retriver the min fulfillment amount of a currency #1690

Open
lemunozm opened this issue Jan 12, 2024 · 0 comments
Open

OrderBook: Runtime API to retriver the min fulfillment amount of a currency #1690

lemunozm opened this issue Jan 12, 2024 · 0 comments
Labels
D8-migration Pull request touches storage and needs migration code. I6-refactoring Code needs refactoring. P2-nice-to-have Issue is worth doing. Q3-medium Can be done with good experience in the language, but little knowledge of the codebase.

Comments

@lemunozm
Copy link
Contributor

Description

The minimum fulfillment amount of a currency is computed in the backend for each currency. Now, it's stored in the Order struct. But this amount does not depend on the order, just on the currency, which is something constant. If we're able to offer a Runtime API to recover such value, we do not need to store it in the Order.

Benefits

  • Less stored on-chain data.
  • Code easy to read & maintain.
@lemunozm lemunozm added Q3-medium Can be done with good experience in the language, but little knowledge of the codebase. P2-nice-to-have Issue is worth doing. I6-refactoring Code needs refactoring. D8-migration Pull request touches storage and needs migration code. labels Jan 12, 2024
@lemunozm lemunozm changed the title OrderBook: Runtime API for retriver the min fulfillment amount of a currency OrderBook: Runtime API to retriver the min fulfillment amount of a currency Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D8-migration Pull request touches storage and needs migration code. I6-refactoring Code needs refactoring. P2-nice-to-have Issue is worth doing. Q3-medium Can be done with good experience in the language, but little knowledge of the codebase.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lemunozm