Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_dio_adapter] Support cronet_http_embedded #2042

Closed
vanyasem opened this issue Nov 25, 2023 · 4 comments · Fixed by dart-lang/http#1111
Closed

[native_dio_adapter] Support cronet_http_embedded #2042

vanyasem opened this issue Nov 25, 2023 · 4 comments · Fixed by dart-lang/http#1111
Labels
fixed p: dependency Targeting packages that's used by dio packages p: native_dio_adapter Targeting `native_dio_adapter` package s: feature This issue indicates a feature request

Comments

@vanyasem
Copy link

Request Statement

cronet_http depends on Google Play Services

There is a separate package called cronet_http_embedded which has no such dependency, but is bigger in size

Solution Brainstorm

I'd like to propose creating a separate package native_dio_adapter_embedded that would depend on cronet_http_embedded instead of cronet_http. We have to support devices that do not have Google Play Services installed.

@vanyasem vanyasem added the s: feature This issue indicates a feature request label Nov 25, 2023
@AlexV525
Copy link
Member

Although I wrote the tool to create the cronet_http_embedded package, I don't think we have a proper way to handle this until Dart team can make its publishing automatic, which can at least avoid the version difference between them.

@AlexV525 AlexV525 added h: need extra help Extra help is needed p: native_dio_adapter Targeting `native_dio_adapter` package p: dependency Targeting packages that's used by dio packages labels Nov 25, 2023
@AlexV525
Copy link
Member

ref: dart-lang/http#1047 (comment)

@vanyasem
Copy link
Author

@AlexV525 thank you for your valuable input! I guess it makes sense to postpone my suggestion until the publishing is made automatic

@ueman
Copy link
Contributor

ueman commented Feb 28, 2024

Cronet embedded is now integrated in the cronet lib. I'm closing this since there's no longer any action needed for this library.

@ueman ueman closed this as completed Feb 28, 2024
@AlexV525 AlexV525 added fixed and removed h: need extra help Extra help is needed labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed p: dependency Targeting packages that's used by dio packages p: native_dio_adapter Targeting `native_dio_adapter` package s: feature This issue indicates a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants