New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JdbcTransactionStorage 关键字 DOMAIN #411

Open

victorkevin2 opened this issue Aug 17, 2023 · 1 comment

victorkevin2 commented Aug 17, 2023

JdbcTransactionStorage 中其中一个列名为 DOMAIN，此名称是Oracle和达梦的保留关键字，导致移植困难，另JdbcStoreProperties的类设计不合理，如果嵌入到已有的数据源DataSource中需要重新#getDataSource方法。

Contributor

nervose commented Aug 29, 2023

JdbcTransactionStorage 中其中一个列名为 DOMAIN，此名称是Oracle和达梦的保留关键字，导致移植困难，另JdbcStoreProperties的类设计不合理，如果嵌入到已有的数据源DataSource中需要重新#getDataSource方法。

已收到您的反馈，后续迭代会考虑进行优化，短期建议使用自定义的StorageType来进行扩展。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment