Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FMG): hide i icon when cell type has <25 cells #3689

Closed
atarashansky opened this issue Dec 7, 2022 · 3 comments
Closed

feat(FMG): hide i icon when cell type has <25 cells #3689

atarashansky opened this issue Dec 7, 2022 · 3 comments
Assignees

Comments

@atarashansky
Copy link
Contributor

atarashansky commented Dec 7, 2022

marker genes can't be found if cell counts is < 25, so we should disable the functionality by hiding the i button

@signechambers1
Copy link

Suggested language: Marker genes are unavailable for cell types with less than 25 cells.

@signechambers1 signechambers1 changed the title feat(FMG): when no marker genes are found for a cell type, panel should indicate that and explain why feat(FMG): hide i icon when cell type has <25 cells Dec 20, 2022
@ashin-czi ashin-czi assigned ashin-czi and unassigned seve Dec 21, 2022
@ashin-czi
Copy link
Contributor

Suggested language: Marker genes are unavailable for cell types with less than 25 cells.

Was something like this what you had in mind?
image

@signechambers1
Copy link

signechambers1 commented Dec 22, 2022

good catch by @karenliang0, @ashin-czi im sorry, we had a convo in slack yesterday and decided to remove the i icon for cell types with less then 25 cells instead of having the panel because we think it is less misleading to users. Is that possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants