From c941235bd066b4626e062362331996f9d149f7ef Mon Sep 17 00:00:00 2001 From: Taras Date: Sat, 9 Oct 2021 11:33:26 +0200 Subject: [PATCH] Fix false positive (#21) --- durationcheck.go | 3 +++ testdata/src/a/a.go | 2 ++ 2 files changed, 5 insertions(+) diff --git a/durationcheck.go b/durationcheck.go index 7f7008e..c47b3a7 100644 --- a/durationcheck.go +++ b/durationcheck.go @@ -150,6 +150,9 @@ func isAcceptableNestedExpr(pass *analysis.Pass, n ast.Expr) bool { case *ast.Ident: return isAcceptableIdent(pass, e) case *ast.CallExpr: + if isAcceptableCast(pass, e) { + return true + } t := pass.TypesInfo.TypeOf(e) return !isDuration(t) case *ast.SelectorExpr: diff --git a/testdata/src/a/a.go b/testdata/src/a/a.go index d8cf13b..2bc13d4 100644 --- a/testdata/src/a/a.go +++ b/testdata/src/a/a.go @@ -74,6 +74,8 @@ func validCases() { _ = time.Second * b.SomeInt _ = time.Duration(intArr[0]) * time.Second + + _ = time.Duration(y) * 24 * time.Hour } func invalidCases() {