Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sidepots #220

Closed
charleskawczynski opened this issue Aug 27, 2023 · 0 comments · Fixed by #222
Closed

Fix sidepots #220

charleskawczynski opened this issue Aug 27, 2023 · 0 comments · Fixed by #222
Labels
bug 🐛 Something isn't working

Comments

@charleskawczynski
Copy link
Owner

The side pots are not properly tracking contributions per player, which is necessary (or at least will be helpful). Related PR: #219
@charleskawczynski charleskawczynski added the bug 🐛 Something isn't working label Aug 27, 2023
@charleskawczynski charleskawczynski mentioned this issue Aug 27, 2023
Merged
bors bot added a commit that referenced this issue Aug 27, 2023
@bors @charleskawczynski
Merge #221
bb388b9 
221: Make sidepot amounts vectors r=charleskawczynski a=charleskawczynski

A step towards #220.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@charleskawczynski charleskawczynski mentioned this issue Aug 27, 2023
Merged
bors bot added a commit that referenced this issue Aug 27, 2023
@bors @charleskawczynski
Merge #222
c75cff2 
222: Improve transaction logic r=charleskawczynski a=charleskawczynski

This PR improves the transaction logic. A step towards #220.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot added a commit that referenced this issue Aug 27, 2023
@bors @charleskawczynski
Merge #222
b4d86a7 
222: Improve transaction logic r=charleskawczynski a=charleskawczynski

This PR improves the transaction logic. A step towards #220.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot added a commit that referenced this issue Aug 27, 2023
@bors @charleskawczynski
Merge #222
47b5ba5 
222: Improve transaction logic r=charleskawczynski a=charleskawczynski

This PR improves the transaction logic. A step towards #220.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot added a commit that referenced this issue Aug 27, 2023
@bors @charleskawczynski
Merge #222
5949b93 
222: Improve transaction logic, fix SimpleRatio underflow r=charleskawczynski a=charleskawczynski

This PR improves the transaction logic and fixes SimpleRatio underflow. Closes #220, #200 and #223.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors bors bot closed this as completed in d41353e Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve transaction logic, fix SimpleRatio underflow charleskawczynski/TexasHoldem.jl
1 participant
@charleskawczynski