Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some jet failures #118

Closed
wants to merge 1 commit into from
Closed

Fix some jet failures #118

wants to merge 1 commit into from

Conversation

charleskawczynski
Copy link
Owner

This PR fixes a bunch of JET failures, and the benchmarks correspondingly have improved a bit (~60μm -> ~55μm)

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Jul 15, 2023
@bors @charleskawczynski
Merge #118
a341fd4 
118: Fix some jet failures r=charleskawczynski a=charleskawczynski

This PR fixes a bunch of JET failures, and the benchmarks correspondingly have improved a bit (~60μm -> ~55μm)

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 15, 2023

Build failed:

@charleskawczynski charleskawczynski mentioned this pull request Jul 15, 2023
Merged
bors bot added a commit that referenced this pull request Jul 15, 2023
@bors @charleskawczynski
Merge #120
169690a 
120: Use more concrete types r=charleskawczynski a=charleskawczynski

This PR uses more concrete types and therefore fixes some jet failures. This actually yields better results than #118.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@charleskawczynski
Copy link
Owner Author

starting fresh with these changes off main

@charleskawczynski charleskawczynski deleted the ck/jet branch July 27, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleskawczynski