Add capability to goto player option #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #196 +/- ##
==========================================
+ Coverage 81.68% 82.08% +0.39%
==========================================
Files 11 12 +1
Lines 1223 1267 +44
==========================================
+ Hits 999 1040 +41
- Misses 224 227 +3
|
charleskawczynski
force-pushed
the
ck/goto_option
branch
from
dae85b2
to
f78309e
Compare
charleskawczynski
force-pushed
the
ck/goto_option
branch
from
f78309e
to
05fe85b
Compare
|
I'm pretty sure this is working. It complicates the code a bit, but it's not too invasive, and most of it is statically elided when we start from the beginning of a fresh game. The only part where we are runtime affected is inside the |
|
bors r+ |
|
bors r- |
|
Canceled. |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is nearly finished, the only quark is that
initial_∑brsis stateful insideplay!, so recomputing it from a preset game ends up corrupting the initial bank rolls. I.e., this needs to be handled more carefully. Re-sampling the games from the river does show different rewards for different options against the Bot5050 🎉Maybe we can bikeshed names a bit.
This is the last thing, AFAICT, needed to do search for training bots.