Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resampling cards #231

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Fix resampling cards #231

merged 2 commits into from
Sep 4, 2023

Conversation

charleskawczynski
Copy link
Owner

Closes #228.

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Sep 4, 2023
231: Fix resampling cards r=charleskawczynski a=charleskawczynski

Closes #228.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #231 (3e767e3) into main (9193644) will increase coverage by 0.71%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   73.54%   74.26%   +0.71%     
==========================================
  Files          17       17              
  Lines        1478     1488      +10     
==========================================
+ Hits         1087     1105      +18     
+ Misses        391      383       -8     
Files Changed Coverage Δ
src/recreate.jl 95.91% <94.11%> (+21.55%) ⬆️

@charleskawczynski charleskawczynski merged commit e209337 into main Sep 4, 2023
20 of 21 checks passed
@bors bors bot deleted the ck/fix_resampling branch September 4, 2023 00:39
@bors
Copy link
Contributor

bors bot commented Sep 4, 2023

This PR was included in a batch that successfully built, but then failed to merge into main (it was a non-fast-forward update). It will be automatically retried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resampling logic is wrong
1 participant