Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure, fix deal and split pot logic, improve names #38

Merged
merged 1 commit into from
May 4, 2021
Merged

Restructure, fix deal and split pot logic, improve names #38

merged 1 commit into from
May 4, 2021

Conversation

charleskawczynski
Copy link
Owner

No description provided.

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request May 1, 2021
@bors @charleskawczynski
Merge #38
ed9ba47 
38: Restructure, fix parts of deal logic, improve names r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@charleskawczynski
Copy link
Owner Author

bors r-

@bors
Copy link
Contributor

bors bot commented May 1, 2021

Canceled.

@codecov
Copy link

codecov bot commented May 1, 2021 •
edited
Loading

Codecov Report

Merging #38 (885ae94) into main (1b7bbc3) will decrease coverage by 3.18%.
The diff coverage is 81.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   73.71%   70.52%   -3.19%     
==========================================
  Files           9       10       +1     
  Lines         407      519     +112     
==========================================
+ Hits          300      366      +66     
- Misses        107      153      +46
Impacted Files Coverage Δ
src/config_game.jl 0.00% <0.00%> (ø)
src/player_options.jl 42.18% <57.69%> (-7.82%) ⬇️
src/table.jl 77.45% <77.45%> (ø)
src/game.jl 85.50% <83.01%> (-14.50%) ⬇️
src/player_types.jl 95.65% <90.00%> (-4.35%) ⬇️
src/game_viz.jl 90.32% <92.85%> (-9.68%) ⬇️
src/player_actions.jl 96.96% <93.33%> (-3.04%) ⬇️
src/transactions.jl 98.68% <98.03%> (-1.32%) ⬇️
src/NoLimitHoldem.jl 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b7bbc3...885ae94. Read the comment docs.

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request May 1, 2021
@bors @charleskawczynski
Merge #38
02c227c 
38: Restructure, fix parts of deal logic, improve names r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 1, 2021

Build failed:

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request May 1, 2021
@bors @charleskawczynski
Merge #38
5f04d7d 
38: Restructure, fix parts of deal logic, improve names r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 1, 2021

Build failed:

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request May 2, 2021
@bors @charleskawczynski
Merge #38
afcdfbe 
38: Restructure, fix parts of deal logic, improve names r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 2, 2021

Build failed:

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request May 2, 2021
@bors @charleskawczynski
Merge #38
7f8f558 
38: Restructure, fix parts of deal logic, improve names r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 2, 2021

Build failed:

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request May 2, 2021
@bors @charleskawczynski
Merge #38
88ac1a3 
38: Restructure, fix parts of deal logic, improve names r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 2, 2021

Build failed:

@charleskawczynski charleskawczynski changed the title Restructure, fix parts of deal logic, improve names Restructure, fix deal and split pot logic, improve names May 4, 2021
@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request May 4, 2021
@bors @charleskawczynski
Merge #38
3d4c683 
38: Restructure, fix deal and split pot logic, improve names r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 4, 2021

Build failed:

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request May 4, 2021
@bors @charleskawczynski
Merge #38
51d86fa 
38: Restructure, fix deal and split pot logic, improve names r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 4, 2021

Build failed:

@charleskawczynski
Copy link
Owner Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 4, 2021

Build succeeded:

@bors bors bot merged commit f036b8c into main May 4, 2021
@bors bors bot deleted the ck/dev branch May 4, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleskawczynski