Several logic fixes and improvements #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
charleskawczynski
commented
May 8, 2021
charleskawczynski
commented
- Fix blinds: now everyone must call to see flop
- Improve call interface (no more need for amount)
- Add func to validate raise amount
- Fix raise logic (no double counting)
- Fix player option dispatch (added CallFold)
- Improve log (include profit in addition to pot amount)
- Fix distribute_winnings! when only 1 player remains
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 8, 2021
44: Several logic fixes and improvements r=charleskawczynski a=charleskawczynski - Fix blinds: now everyone must call to see flop - Improve call interface (no more need for amount) - Add func to validate raise amount - Fix raise logic (no double counting) - Fix player option dispatch (added CallFold) - Improve log (include profit in addition to pot amount) - Fix distribute_winnings! when only 1 player remains Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
- Fix blinds: now everyone must call to see flop - Improve call interface (no more need for amount) - Add func to validate raise amount - Fix raise logic (no double counting) - Fix player option dispatch (added CallFold) - Improve log (include profit in addition to pot amount) - Fix distribute_winnings! when only 1 player remains
|
Canceled. |
|
bors r+ |
Codecov Report
@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 73.57% 74.80% +1.23%
==========================================
Files 8 8
Lines 507 631 +124
==========================================
+ Hits 373 472 +99
- Misses 134 159 +25
Continue to review full report at Codecov.
|
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.