Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve names, add some helper funcs, add some docs #47

Merged
merged 1 commit into from
May 10, 2021
Merged

Improve names, add some helper funcs, add some docs #47

merged 1 commit into from
May 10, 2021

Conversation

charleskawczynski
Copy link
Owner

@charleskawczynski charleskawczynski commented May 10, 2021 •
edited
Loading

Peel some things off of #46.

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request May 10, 2021
@bors @charleskawczynski
Merge #47
e5a40e1 
47: Improve names, add some helper funcs, add some docs r=charleskawczynski a=charleskawczynski

Peel some things off of #46.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@charleskawczynski
Copy link
Owner Author

bors r-

@bors
Copy link
Contributor

bors bot commented May 10, 2021

Canceled.

@codecov
Copy link

codecov bot commented May 10, 2021 •
edited
Loading

Codecov Report

Merging #47 (9b98a7c) into main (ac8ab39) will increase coverage by 0.70%.
The diff coverage is 78.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   74.80%   75.50%   +0.70%     
==========================================
  Files           8        8              
  Lines         631      641      +10     
==========================================
+ Hits          472      484      +12     
+ Misses        159      157       -2
Impacted Files Coverage Δ
src/TexasHoldem.jl 100.00% <ø> (ø)
src/player_types.jl 89.47% <25.00%> (-4.98%) ⬇️
src/game.jl 97.95% <50.00%> (-1.01%) ⬇️
src/player_options.jl 45.78% <69.56%> (-3.66%) ⬇️
src/player_actions.jl 92.13% <83.33%> (-1.46%) ⬇️
src/table.jl 95.53% <100.00%> (+5.44%) ⬆️
src/transactions.jl 89.70% <100.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac8ab39...9b98a7c. Read the comment docs.

@charleskawczynski
Copy link
Owner Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 10, 2021

Build succeeded:

@bors bors bot merged commit 7803f70 into main May 10, 2021
@bors bors bot deleted the ck/refactor branch May 10, 2021 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleskawczynski