Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 59 #62

Merged
merged 1 commit into from
May 13, 2021
Merged

Fix 59 #62

merged 1 commit into from
May 13, 2021

Conversation

charleskawczynski
Copy link
Owner

@charleskawczynski charleskawczynski commented May 13, 2021

Running in debug mode (over 1k games) revealed that all_checked_or_folded(table) was returning true even when a player raised, which meant that it needed to be flipped after raise_to! and call!.

Closes #59.

@charleskawczynski
Copy link
Owner Author

bors r+

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #62 (74fec04) into main (b04dd84) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   84.06%   84.15%   +0.09%     
==========================================
  Files           8        8              
  Lines         665      669       +4     
==========================================
+ Hits          559      563       +4     
  Misses        106      106              
Impacted Files Coverage Δ
src/player_actions.jl 100.00% <100.00%> (ø)
src/player_options.jl 95.37% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04dd84...74fec04. Read the comment docs.

@bors bors bot merged commit a2b484e into main May 13, 2021
@bors bors bot deleted the ck/fix_59 branch May 13, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes raises are not called
1 participant