Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring changes, improve names, use more inactive flags #71

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Small refactoring changes, improve names, use more inactive flags #71

merged 1 commit into from
Jun 4, 2021

Conversation

charleskawczynski
Copy link
Owner

@charleskawczynski charleskawczynski commented Jun 4, 2021 •
edited
Loading

This PR

  • Protects a bit more against cases with inactive players
  • Removes the 10-player fuzz tournament play

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Jun 4, 2021
@bors @charleskawczynski
Merge #71
8cbf5ac 
71: Small refactoring changes, improve names, use more inactive flags r=charleskawczynski a=charleskawczynski

These changes should protect a bit more against cases with inactive players

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jun 4, 2021

Build failed:

@charleskawczynski
Copy link
Owner Author

bors r+

@codecov
Copy link

codecov bot commented Jun 4, 2021 •
edited
Loading

Codecov Report

Merging #71 (5b9995b) into main (1c471f4) will decrease coverage by 0.25%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   86.23%   85.97%   -0.26%     
==========================================
  Files           8        8              
  Lines         828      827       -1     
==========================================
- Hits          714      711       -3     
- Misses        114      116       +2
Impacted Files Coverage Δ
src/table.jl 96.83% <83.33%> (-1.29%) ⬇️
src/game.jl 99.30% <100.00%> (ø)
src/player_actions.jl 100.00% <100.00%> (ø)
src/player_types.jl 97.29% <100.00%> (+0.07%) ⬆️
src/transactions.jl 89.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c471f4...5b9995b. Read the comment docs.

@bors
Copy link
Contributor

bors bot commented Jun 4, 2021

Build succeeded:

@bors bors bot merged commit bbbc107 into main Jun 4, 2021
@bors bors bot deleted the ck/skip_inactive branch June 4, 2021 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleskawczynski