Improve iterators #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 7, 2021
80: Improve iterators r=charleskawczynski a=charleskawczynski - Button -> Dealer - circle_table -> circle_index, which only takes the length and state for indexing `players` - Remove position - add `n_iter` to iterators, so that we can collect the results and simplify the tests Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
bors r- |
|
Canceled. |
charleskawczynski
force-pushed
the
ck/fix_iterators
branch
from
ded08e5
to
b010a02
Compare
|
bors r+ |
|
Closes #81 |
|
This doesn't close #73, but we may be able to just skip non-active players on the fly. This PR at least ensures that we start iterating on only active players. |
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 86.81% 87.20% +0.39%
==========================================
Files 8 8
Lines 872 899 +27
==========================================
+ Hits 757 784 +27
Misses 115 115
Continue to review full report at Codecov.
|
This was referenced Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
circle_table->circle_index, which only takes the length and state for indexingplayerspositionn_iterto iterators, so that we can collect the results and simplify the tests