Ensure raises are called, fix edge cases with player options #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/called_raises
branch
from
777e656
to
795b0bb
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 12, 2021
85: Ensure raises are called, fix edge cases with player options r=charleskawczynski a=charleskawczynski This PR - Adds an assertion to ensure raises are called (via `all_raises_were_called`) - Fixes an edge cases where players are incorrectly given options when they shouldn't have any. For example, consider a heads-up game when the small blind player calls small blind (and is then all-in), the big blind has paid the blind, and has no action to make. In this case, the big blind was incorrectly given the option to check/raise/fold, which lead to downstream errors. - Adding `!action_required(br_leader)` to `cond3` helped fix an edge case (maybe helped with the same one above?) Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Build failed: |
charleskawczynski
force-pushed
the
ck/called_raises
branch
from
795b0bb
to
0037691
Compare
|
bors try |
tryBuild failed: |
charleskawczynski
force-pushed
the
ck/called_raises
branch
from
0037691
to
0d2f4b1
Compare
|
bors try |
Codecov Report
@@ Coverage Diff @@
## main #85 +/- ##
==========================================
+ Coverage 87.34% 87.56% +0.21%
==========================================
Files 8 8
Lines 901 949 +48
==========================================
+ Hits 787 831 +44
- Misses 114 118 +4
Continue to review full report at Codecov.
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 13, 2021
85: Ensure raises are called, fix edge cases with player options r=charleskawczynski a=charleskawczynski This PR - Adds an assertion to ensure raises are called (via `all_raises_were_called`) - Fixes an edge cases where players are incorrectly given options when they shouldn't have any. For example, consider a heads-up game when the small blind player calls small blind (and is then all-in), the big blind has paid the blind, and has no action to make. In this case, the big blind was incorrectly given the option to check/raise/fold, which lead to downstream errors. - Adding `!action_required(br_leader)` to `cond3` helped fix an edge case (maybe helped with the same one above?) Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Hopefully this is the last time... closes #59 |
|
Build failed: |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
all_raises_were_called)!action_required(br_leader)tocond3helped fix an edge case (maybe helped with the same one above?)