Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customWorkspaces versions #3072

Open
lpatiny opened this issue Jun 1, 2024 · 0 comments
Open

customWorkspaces versions #3072

lpatiny opened this issue Jun 1, 2024 · 0 comments
Assignees

Comments

@lpatiny
Copy link
Member

lpatiny commented Jun 1, 2024

Version has been removed from the workspaces and the issue now is that we can not specify version of customWorkspaces.

version: 2,
label: 'Simple NMR analysis',

In order to get the version I guess the best is to change customWorkspaces properties to only accept array like:

[
  {
    version: 7, <-- NMRium version
    name: 'My custom settings',
    settings: {}, <-- the normal settings object without version
  }
]

Likely that nobody is using this feature so we can make this change without any migration scripts. It is mainly our examples in this project that needs to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants