Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlightr broken in 0.15.9 even after latest update #47

Closed
KraXen72 opened this issue Sep 1, 2022 · 8 comments
Closed

highlightr broken in 0.15.9 even after latest update #47

KraXen72 opened this issue Sep 1, 2022 · 8 comments

Comments

@KraXen72
Copy link

KraXen72 commented Sep 1, 2022

image
doesen't create the right click menu for "highlight" at all

@KraXen72 KraXen72 changed the title highlightr broken in 0.15.09 even after latest update highlightr broken in 0.15.9 even after latest update Sep 1, 2022
@chetachiezikeuzor
Copy link
Owner

Geez, alright I understand the issue now. I'm using a function in the new update that's only available in Obsidian 0.16.0 Insider build. Sorry for this, I'll fix this as soon as possible. Thank you for your patience!

@archaeaMby
Copy link

KraXen72, I encountered the same problem. Thank you for putting your issue here!
Chetachi, Thank you for developing such a great plugin!

@tankilo
Copy link

tankilo commented Sep 23, 2022

Expect this problem to be fixed.

@cremepvff
Copy link

highlighter is still not working, unsure if this has been fixed yet

@dlion
Copy link

dlion commented Oct 4, 2022

Yep, it is still broken.
@chetachiezikeuzor Do you have any ETA for this?


UPDATE: uh, I saw that with the last commit, the problem had been fixed: 61341a4, but I guess we still don't have a plugin update.
Patching the local version it works again

@KraXen72 KraXen72 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 20, 2023
@KraXen72 KraXen72 reopened this Aug 20, 2023
@yarub123
Copy link

@dlion Hey dude from 2 years ago. Hope you're well.

Just curious how would I go about locally patching it? I'm browsing the files of that commit that you mentioned but don't see main.js (probably since it's on "releases.") Is there a way to go about doing it?

@dlion
Copy link

dlion commented Jan 29, 2024

Hey @yarub123 , I think the issue was fixed a long time ago.
BTW if you want to have a local patch you can edit the local version of the plugin. For example, in this case, you can just find your Highlightr plugin folder, find the file src/ui/highlighterMenu.ts, and edit it. Re-open Obsidian and done.
Be aware that every time you update the plugin your changes will be overridden.

@yarub123
Copy link

@dlion Good man. Appreciate the response. I figured it out yesterday. Something was wrong with my obsidian, a simple restart fixed it. I forgot to update my comment in here, but it's still good to know. Thanks again brotha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants