fix: add tooltip positions for status bar menu buttons & change menu width #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change menu width to `fit-content` to stop long snippet filenames from being truncated. This is especially helpful when using namespaced snippets where the scope or function is at the end of the filename. Fixes chetachiezikeuzor#11
re4mat
changed the title
|
Change menu width to Fixes: #11
Screenshot from before the changeNote
Screenshot from after the changeNote |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltips for the status bar icon and menu had no explicit "data-tooltip-position" attribute set, causing them all to be auto-positioned as "bottom" when invoked.
This change adds
setAttributes({"data-tooltip-position":"top"})to the status bar button and all the menu buttons.Screenshots from before the change
Note
Screenshots from after the change
Note