Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Stage three sams #417

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[WIP] Stage three sams #417

wants to merge 4 commits into from

Conversation

hannahbrucemacdonald
Copy link
Contributor

Adding option for third-stage sams, where the third and final stage runs with fixed weights.
The stage update protocol involves both a criteria (logz/histogram/visits) and a threshold for 2nd stage.

If the third stage has the same criteria as second stage, a check is made during set up that the third-stage is a tighter (more stringent threshold criteria) during set up. If the third stage criteria differs from the second stage criteria then the thresholds cannot be compared, and instead, if during simulation, the third-stage criteria is already met when the second-stage criteria is met then the simulation will revert to a two-stage update scheme.

@jchodera
Copy link
Member

This looks like a good choice for API and YAML support for now! We can always generalize this later once we get things working robustly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants