Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up restraint centroid distance calculation #962

Open
andrrizzi opened this issue Apr 24, 2018 · 3 comments
Open

Speed up restraint centroid distance calculation #962

andrrizzi opened this issue Apr 24, 2018 · 3 comments

Comments

@andrrizzi
Copy link
Contributor

Possible speed enhancements:

  • Add an optional keyword to Reporter.read_sampler_states(, atom_indices=None) to read only a subset of positions from disk.
  • Check if it's worth implementing directly an algorithm to compute the centroid distance without going through mdtraj.Trajectory.image_molecules().
@jchodera
Copy link
Member

jchodera commented May 2, 2018

Another possibility is to convert all restraints to use CustomCVForce and retrieve all registered CVs for each CustomCVForce and store them each iteration. This will add almost no overhead during simulation and make analysis near instantaneous, even if the cutoffs or bound state definitions (in terms of CVs) are changed.

@jchodera jchodera added this to the 0.23.0 milestone May 26, 2018
@jchodera jchodera removed this from the 0.23.0 milestone Aug 19, 2018
@jchodera
Copy link
Member

This should be fixed once we convert to CustomCVForce.

@andrrizzi
Copy link
Contributor Author

andrrizzi commented Aug 20, 2018

For record-keeping: This was implemented in #1059, but it hasn't been merged to master yet. It's now in the multirestraint branch, and it will require an openmmtools release (of the features implemented in choderalab/openmmtools#365, now in its multi-restraint branch) and some fixes to the analysis before being usable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants