Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local development: support 127.0.0.1 too #123

Open
XhmikosR opened this issue Oct 25, 2017 · 2 comments
Open

Local development: support 127.0.0.1 too #123

XhmikosR opened this issue Oct 25, 2017 · 2 comments

Comments

@XhmikosR
Copy link
Contributor

XhmikosR commented Oct 25, 2017

So, after I set up the local env, I visited 127.0.0.1:8080. Now, I know the README states localhost but localhost translates to 127.0.0.1 too so if it's not too much trouble both should be supported.

@lgarron
Copy link
Collaborator

lgarron commented Oct 25, 2017

shakes fist at Google Cloud

This should be easy, but every time I touch the relevant file I also cause a bug due to unforeseen issues with Google Cloud:

func isLocalhost(hostport string) bool {
host, _, err := net.SplitHostPort(hostport)
return err == nil && host == "localhost"
}

@XhmikosR
Copy link
Contributor Author

@lgarron: something else I wonder after setting things up locally. In README.md you mention:

cd $GOPATH/src/github.com/chromium/hstspreload.org

I personally just had to cd to the repository and do make serve. Also $GOPATH isn't available on my Windows VM, $GOROOT was set though by the installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants