Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted domains should not expire #1646

Open
3 tasks
vickyszuchin opened this issue Jan 17, 2024 · 2 comments
Open
3 tasks

Deleted domains should not expire #1646

vickyszuchin opened this issue Jan 17, 2024 · 2 comments

Comments

@vickyszuchin
Copy link

vickyszuchin commented Jan 17, 2024

Issue description

On Manage Domains, a domain must conform to the following business rules regarding domain status:

  • Deleted: deleted domains can NOT be expired
  • Unknown: unknown domains can NOT be expired
  • ALL other statuses (included on hold): can be expired

Currently, the last two in the list above are already covered by our set up in this PR we only need to make sure that deleted domains are given the same exception that unknown domains were.

Discussion slack thread

Acceptance criteria

On Manage Domains:

  • Deleted domain does NOT show as "Expired" on the overview page or when clicking manage domains
  • Deleted domain do not show the expired date, even if it exists {THIS NEEDS TO BE CONFIRMED}
  • Add unit test as appropriate.

Additional context

On deleted domain (per Alysia):

In Cloudflare, once it’s deleted on our side there is some time that it takes for the delete to take affect. The domain’s expiration date won’t change but it will never really count as expired as it’s going through the delete process (at least from what I can tell). Once it’s deleted from the zone, it no longer has an expiration date because it doesn’t exist in the zone. All data on it would eventually disappear on Cloudflare’s side. So our system should be changed so that if it is deleted we do not show Expired, no matter what.

Links to other issues

Related to: #804

@vickyszuchin vickyszuchin changed the title Deleted domains can not be expired; On-hold domains can expire Deleted domains can not expired; On-hold domains can expire Jan 17, 2024
@abroddrick abroddrick changed the title Deleted domains can not expired; On-hold domains can expire Deleted domains can not expired Jan 17, 2024
@h-m-f-t h-m-f-t changed the title Deleted domains can not expired Deleted domains should not expire Mar 7, 2024
@vickyszuchin
Copy link
Author

vickyszuchin commented Mar 7, 2024

Refinement tag added: per Cameron (3/6/2024) on AC #2:

I think it should show the expiration date in-registrar, it should just be an input into the domain's status. IOW, for history's sake, let's keep the expiration date and not hide it, but not have the date matter for a deleted domain's state.

Pending finalization of AC#2. cc: @abroddrick @PaulKuykendall

@PaulKuykendall
Copy link

Deleted state is more important than expired state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🍦 Backlog
Development

No branches or pull requests

3 participants