tweak(conhost): use circular_buffer instead of ImVector #2728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fix crash when printing a large amount of things to console (2501+) due to
ItemTimes
using aImVector
instead ofcircular_buffer
.How is this PR achieving the goal
Replace
ImVector
with acircular_buffer
so that it properly caps out at2500
items instead of allowing it to infinity expand as a Vector, causing a crash later when it tries to removeItems
andItemKeys
because they are properly restricted to2500
items and will try to remove past the bounds ifItems
.fivem/code/components/conhost-v2/src/ConsoleHostGui.cpp
Lines 729 to 734 in 705cd79
This PR applies to the following area(s)
FiveM/RedM
Successfully tested on
Game builds: N/A
Platforms: N/A
Checklist