Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak(conhost): use circular_buffer instead of ImVector #2728

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tweak(conhost): use circular_buffer instead of ImVector #2728

wants to merge 1 commit into from

Commits on Aug 19, 2024

  1. tweak(conhost): use circular_buffer instead of ImVector 

    - `Items` and `ItemKeys` use a circular buffer and can only store `2500` items, but ItemTimes could expand and store more.
- This would cause a crash at https://github.com/citizenfx/fivem/blob/705cd7901ac03c5a0d1e1355d94e84046309b80d/code/components/conhost-v2/src/ConsoleHostGui.cpp#L729-L734 because `ItemTimes` would have a capacity of 2500+ but `Items` and ItemKeys` would be empty
    @AvarianKnight
    AvarianKnight committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    cedb91f View commit details
    Browse the repository at this point in the history