Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extra-natives/five): fix crosshair bottom line drawn incorrectly #2733

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JohnDeved
Copy link
Contributor

@JohnDeved JohnDeved commented Aug 20, 2024

Goal of this PR

there is a recent issue introduced that causes the bottom line of the crosshair to render incorrectly
image
the bottom line ignores the gap and starts in at the center

How is this PR achieving the goal

made use of iInnerBottom for the line start instead of iCenterY

This PR applies to the following area(s)

FiveM

Successfully tested on

not tested

Platforms: Windows, Linux

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

fixes an issue introduced in #2544

@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged labels Aug 20, 2024
@JohnDeved JohnDeved marked this pull request as draft August 24, 2024 19:58
@JohnDeved JohnDeved marked this pull request as ready for review August 24, 2024 19:58
@FabianTerhorst FabianTerhorst self-assigned this Aug 26, 2024
@Sasino97
Copy link

@JohnDeved Please fix, hundreds of players are waiting for this fix 🙏
image

@prikolium-cfx prikolium-cfx added ready-to-merge This PR is enqueued for merging and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants