feat(server/state): add [GET/SET]_ENTITY_ORPHAN_MODE
#2741
+155
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
invalid
AvarianKnight
force-pushed
the
feat/server/orphan-modes
branch
from
7a7a6c9
to
552932b
Compare
prikolium-cfx
added
triage
- this allows the end user to be able to define how they want an entity to be deleted instead of automatically cleaning up every entity on entity GC - this is mainly useful for allowing the server to keep specific client entities (like vehicles) from being automatically deleted - this allows for the same persistence as server created entities but without the draw backs. - also allows for specific entities (like objects) to be marked for deletion whenever the client leaves the server
AvarianKnight
force-pushed
the
feat/server/orphan-modes
branch
from
552932b
to
e7ec01f
Compare
github-actions
bot
added
invalid
FabianTerhorst
approved these changes
Sep 27, 2024
FabianTerhorst
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Allow server owners to choose how they want the entity to be treated when it no longer has a valid/relevant owner.
This will allow for servers to use client side
CREATE_*natives while being able keep the entity relatively persistent like the server setters, and also avoiding some of the known bugs with server-setters.This will also allow the server owner to have specific entities be deleted whenever they leave the server.
How is this PR achieving the goal
Add
EntityOrphanModes to let the server owner choose how they want an entity to be treated when the entity loses its first owner or is no longer relevant.This PR applies to the following area(s)
Server
Successfully tested on
Game builds: N/A
Platforms: Windows
Checklist