Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nui): Allow DUI Keyboard Input #2770

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mycroft-Studios
Copy link

Goal of this PR

A better version of: PR #2195 , to add the ability to use keyboard inputs in DUI.
Please See this forums post for why this ability would be very useful.

Currently keyboard inputs are:
A. impossible on any external sites
B. very janky and too specific (having to apply the code to each individual input) on internal UI

How is this PR achieving the goal

This PR adds 2 brand new natives:
SET_DUI_KEYBOARD_INPUT - Works the same way as NUI focus, but for DUI
KEYBOARD_HAS_KEYBOARD_INPUT - to check if the dui is currently focused or not

This PR applies to the following area(s)

Natives,
NUI,
DUI

Checklist

  • [ x] Code compiles and has been tested successfully.
  • [ x] Code explains itself well and/or is documented.
  • [ x] My commit message explains what the changes do and what they are for.
  • [ x] No extra compilation warnings are added by these changes.

Adds the ability to use the keyboard in DUI
@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Sep 4, 2024
@Mycroft-Studios Mycroft-Studios changed the title Feat(nui): Allow DUI Keyboard Input feat(nui): Allow DUI Keyboard Input Sep 6, 2024
@Nobelium-cfx
Copy link
Contributor

I believe validate PR check fails because you need to change title of the commit itself. While you have changed title of the PR.

You can amend the commit you've made and force push the change. Something like this should work

git commit --amend -m "feat(nui): Allow DUI Keyboard Input"
git push --force

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Requires changes before it's considered valid and can be (re)triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants