Updating Hamlib to v4+ #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
vsonnier
force-pushed
the
vso_update_to_hamlib_v40
branch
from
150d4fd
to
d2dedbb
Compare
|
Updated for v4.1, changed title and such. |
vsonnier
force-pushed
the
vso_update_to_hamlib_v40
branch
from
d2dedbb
to
50d7a36
Compare
Closed
vsonnier
force-pushed
the
vso_update_to_hamlib_v40
branch
from
50d7a36
to
619a16f
Compare
|
Hamlib v4.2 has just been released: it runs under Win32 / Win64 without crashing this time. |
vsonnier
commented
May 23, 2021
| @@ -114,7 +114,7 @@ void RigThread::run() { | |||
| std::cout << "Rig thread starting." << std::endl; | |||
|
|
|||
| rig = rig_init(rigModel); | |||
| strncpy(rig->state.rigport.pathname, rigFile.c_str(), FILPATHLEN - 1); | |||
| strncpy(rig->state.rigport.pathname, rigFile.c_str(), HAMLIB_FILPATHLEN - 1); | |||
There was a problem hiding this comment.
The only change I made on CubicSDR source is here:
vsonnier
force-pushed
the
vso_update_to_hamlib_v40
branch
from
619a16f
to
b2b178e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hamlib 4+ has been relreased : https://github.com/Hamlib/Hamlib/releases/tag/4.1
This is the update of Hamlib to v4+, in particular Windows binaries.
So far I modified
CMakeLists.txtto accomodate the lib name change (-4instead of-2) and added the Windows binaries, and one constant in a Cubic .cppSo far it compiles (with warnings) both for Win32 and Win64 using VS2019 v16.5
Edit :
2021-03-03:18:22:20.712339: rig_mW2power calledthen segfault. :(I'm using in both cases the Win Dlls from the Hamlib releases .
Vincent