Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet tool? #10

Closed
KirillOsenkov opened this issue Aug 23, 2024 · 7 comments
Closed

dotnet tool? #10

KirillOsenkov opened this issue Aug 23, 2024 · 7 comments

Comments

@KirillOsenkov
Copy link
Contributor

@cklutz once again thank you for creating this indispensable library!

Have you thought about publishing a dotnet global tool like lockcheck.exe such that you could run it from command line?

Long ago this used to be a console .exe project, but now it seems to be a library only?

@KirillOsenkov
Copy link
Contributor Author

I pushed a branch in my fork if you're interested:
https://github.com/KirillOsenkov/LockCheck/tree/tool

@KirillOsenkov
Copy link
Contributor Author

I published https://www.nuget.org/packages/lockchecktool and added you as an owner if you're interested. Happy to make a PR to this repo too.

@KirillOsenkov
Copy link
Contributor Author

There you go!

image

@cklutz
Copy link
Owner

cklutz commented Aug 26, 2024

Oh yes, nice idea. Haven't thought about that. Go figure! :-)

I'm a bit busy for the next couple of weeks, but after that (or before, if possible at all), I'd gladly like to merge a PR. Thanks for the ownership offer. I accepted it in the hopes I can provide some value eventually.

@KirillOsenkov
Copy link
Contributor Author

Here you go:
#11

no rush!

@cklutz
Copy link
Owner

cklutz commented Oct 1, 2024

Finally :-) I merged it. Sorry for taking so long and thanks again! I will have to do some more work on this library in the next weeks (hopefully) the Linux tests are (still) broken and some other stuff...

I will close this issue for now, but feel free to let me know if we need to do some more things about this (tool).

@cklutz cklutz closed this as completed Oct 1, 2024
@cklutz
Copy link
Owner

cklutz commented Oct 1, 2024

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants