Support delimited values for native completions

[epage]

See #3166 for more context

• code
• tests

[epage]

@shannmu is there a reason #5602 didn't close this?

[shannmu]

The issue still seems to be related to allow_hyphen_values, where the completion for the delimited option includes the possible values of positional arguments (if they are also delimited). This is not caused by this issue, but it shows that the issue has not been fully resolved.

[epage]

I don't what allow_hyphen_values has to do with value_delimiter. I don't quite understand your explanation. Mind re-phrasing or providing examples?

[shannmu]

clap/clap_complete/tests/testsuite/dynamic.rs

Lines 673 to 683 in d811585

	assert_data_eq!(
	complete!(cmd, "--delimiter=comma,[TAB]"),
	snapbox::str![
	"--delimiter=comma,comma
	--delimiter=comma,space
	--delimiter=comma,tab
	--delimiter=comma,a_pos
	--delimiter=comma,b_pos
	--delimiter=comma,c_pos"
	]
	);

--delimiter=comma is treated as a delimited positional argument. We complete positional argument without conditions required when the current state is ValueDone, so it will call complete_arg_value.

clap/clap_complete/src/dynamic/complete.rs

Lines 216 to 221 in d811585

	if let Some(positional) = cmd
	.get_positionals()
	.find(|p| p.get_index() == Some(pos_index))
	{
	completions.extend(complete_arg_value(arg.to_value(), positional, current_dir));
	}

[epage]

@shannmu I had missed that. If there is a known issue in a PR, call it out. That should have been discussed before merging.