Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend tool calling API to also support HTTP POST #69

Open
proycon opened this issue Dec 14, 2019 · 1 comment
Open

Extend tool calling API to also support HTTP POST #69

proycon opened this issue Dec 14, 2019 · 1 comment

Comments

@proycon
Copy link

proycon commented Dec 14, 2019

If I understand things correctly, currently the tool calling API always does a HTTP get passing a URL that the remote service should download. This is a good solution but not all services will support this, some may require a POST (or PUT) request with the actual data in the content body.

An example is FLAT (clarin-eric/switchboard-tool-registry#7), which current expects a specifically formatted POST request. Now since this is my own tool I could of course add a switchboard-compliant endpoint with relative ease, but that's won't always be the case with all services, and I wonder to what extent the switchboard tool calling API itself shouldn't become more flexible, rather than putting this burden on the tools to be called. More flexibility would lead to easier incorporation of more tools.

@emanueldima
Copy link
Collaborator

I think that allowing for some flexibility is a good idea, so we should keep this in mind. Other things to keep in mind: 1. Using POST may not work with services that require Shibboleth authentication. 2. If the client sends the data to the service directly (by POST), this means more data traffic on mobile connections.

To be considered in #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants