Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build outside of version control (0.4.0) #175

Closed
drjdn opened this issue Nov 21, 2015 · 4 comments · Fixed by #1296
Closed

Cannot build outside of version control (0.4.0) #175

drjdn opened this issue Nov 21, 2015 · 4 comments · Fixed by #1296
Milestone

Comments

@drjdn
Copy link

drjdn commented Nov 21, 2015

I think there is missing git information in the tar.gz of the recent release (congrats on the new release). I get messages like the following:

fatal: Not a git repository (or any parent up to mount point

If I clone from master everything builds fine and the proper submodules are pulled.

Best regards,
Jason

@Georgiy-Tugai
Copy link
Contributor

This is a known issue with using git describe and friends for version detection; thanks for reminding us about this, though 👍

@Georgiy-Tugai Georgiy-Tugai added this to the 0.5.0 milestone Nov 22, 2015
@Shinmera
Copy link
Contributor

Gah, and here I thought I had worked around that problem in the makefile. This is what I get for not testing.

@Georgiy-Tugai
Copy link
Contributor

@Shinmera Is there any procedure for releases at the moment other than "click the release button on github"?

@Georgiy-Tugai Georgiy-Tugai changed the title Missing git info in clasp-0.4.0.tar.gz Cannot build outside of version control (0.4.0) Nov 22, 2015
@Georgiy-Tugai
Copy link
Contributor

Title changed since version info is the least of our problems here. Submodules are pulled in by the Makefile, and Github's tarballs include empty directories where submodules are meant to be.

@Shinmera Shinmera modified the milestones: 1.0.0, 0.5.0 Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants