From 6188c1309a99b1c3e339ea1777e1b20f371b9a5a Mon Sep 17 00:00:00 2001 From: Edwin Chong <5728235+ewchong@users.noreply.github.com> Date: Fri, 15 Oct 2021 14:41:08 -0400 Subject: [PATCH] fix review comments --- snafu/benchmarks/coremarkpro/Dockerfile | 3 +-- snafu/benchmarks/coremarkpro/__init__.py | 2 +- snafu/benchmarks/coremarkpro/ci_test.sh | 1 - 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/snafu/benchmarks/coremarkpro/Dockerfile b/snafu/benchmarks/coremarkpro/Dockerfile index f23d1d5e9..48f675755 100644 --- a/snafu/benchmarks/coremarkpro/Dockerfile +++ b/snafu/benchmarks/coremarkpro/Dockerfile @@ -1,5 +1,5 @@ FROM registry.access.redhat.com/ubi8:latest -MAINTAINER Sai Sindhur Malleni +MAINTAINER Ed Chong RUN dnf install -y --nodocs make git gcc && dnf clean all RUN git clone https://github.com/eembc/coremark-pro.git && cd coremark-pro && ls util/make && make TARGET=linux64 build @@ -8,6 +8,5 @@ WORKDIR /output/ RUN dnf install -y --nodocs python3.8 python38-devel procps-ng iproute net-tools ethtool nmap iputils && dnf clean all RUN ln -s /usr/bin/python3 /usr/bin/python RUN pip3 install --upgrade pip -#RUN echo -e '[global]\nextra-index-url=https://www.piwheels.org/simple' > /etc/pip.conf COPY . /opt/snafu RUN pip3 install -r /opt/snafu/requirements/py38-reqs/install.txt -e /opt/snafu diff --git a/snafu/benchmarks/coremarkpro/__init__.py b/snafu/benchmarks/coremarkpro/__init__.py index 1d3d217af..b039ba581 100644 --- a/snafu/benchmarks/coremarkpro/__init__.py +++ b/snafu/benchmarks/coremarkpro/__init__.py @@ -1,5 +1,5 @@ #!/usr/bin/env python3 # -*- coding: utf-8 -*- # flake8: noqa -"""Uperf benchmark""" +"""Coremarkpro benchmark""" from snafu.benchmarks.coremarkpro.coremarkpro import Coremarkpro diff --git a/snafu/benchmarks/coremarkpro/ci_test.sh b/snafu/benchmarks/coremarkpro/ci_test.sh index ff12d338c..1992ce702 100755 --- a/snafu/benchmarks/coremarkpro/ci_test.sh +++ b/snafu/benchmarks/coremarkpro/ci_test.sh @@ -8,4 +8,3 @@ source ci/common.sh image_spec=$SNAFU_WRAPPER_IMAGE_PREFIX/coremark-pro:$SNAFU_IMAGE_TAG build_and_push snafu/coremarkpro/Dockerfile $image_spec pushd ripsaw -source tests/test_coremarkpro.sh