diff --git a/src/resources/pages/projects/deployments/deployments.ts b/src/resources/pages/projects/deployments/deployments.ts index 30cf9aef23..bea24ac177 100644 --- a/src/resources/pages/projects/deployments/deployments.ts +++ b/src/resources/pages/projects/deployments/deployments.ts @@ -36,12 +36,12 @@ export class Deployments extends APIResource { params: DeploymentListParams, options?: Core.RequestOptions, ): Core.APIPromise { - const { account_id } = params; + const { account_id, ...query } = params; return ( - this._client.get( - `/accounts/${account_id}/pages/projects/${projectName}/deployments`, - options, - ) as Core.APIPromise<{ result: DeploymentListResponse }> + this._client.get(`/accounts/${account_id}/pages/projects/${projectName}/deployments`, { + query, + ...options, + }) as Core.APIPromise<{ result: DeploymentListResponse }> )._thenUnwrap((obj) => obj.result); } @@ -136,9 +136,14 @@ export interface DeploymentCreateParams { export interface DeploymentListParams { /** - * Identifier + * Path param: Identifier */ account_id: string; + + /** + * Query param: What type of deployments to fetch. + */ + env?: 'production' | 'preview'; } export interface DeploymentDeleteParams { diff --git a/src/resources/pages/projects/projects.ts b/src/resources/pages/projects/projects.ts index b05419a12c..1c4727a828 100644 --- a/src/resources/pages/projects/projects.ts +++ b/src/resources/pages/projects/projects.ts @@ -670,6 +670,11 @@ export namespace PagesProjects { * Service binding. */ export interface ServiceBinding { + /** + * The entrypoint to bind to. + */ + entrypoint?: string | null; + /** * The Service environment. */ @@ -1039,6 +1044,11 @@ export namespace PagesProjects { * Service binding. */ export interface ServiceBinding { + /** + * The entrypoint to bind to. + */ + entrypoint?: string | null; + /** * The Service environment. */ @@ -1510,6 +1520,11 @@ export namespace ProjectCreateParams { * Service binding. */ export interface ServiceBinding { + /** + * The entrypoint to bind to. + */ + entrypoint?: string | null; + /** * The Service environment. */ @@ -1879,6 +1894,11 @@ export namespace ProjectCreateParams { * Service binding. */ export interface ServiceBinding { + /** + * The entrypoint to bind to. + */ + entrypoint?: string | null; + /** * The Service environment. */ diff --git a/tests/api-resources/pages/projects/deployments/deployments.test.ts b/tests/api-resources/pages/projects/deployments/deployments.test.ts index cb74a010b2..9aa37b28d8 100644 --- a/tests/api-resources/pages/projects/deployments/deployments.test.ts +++ b/tests/api-resources/pages/projects/deployments/deployments.test.ts @@ -50,6 +50,7 @@ describe('resource deployments', () => { test.skip('list: required and optional params', async () => { const response = await cloudflare.pages.projects.deployments.list('this-is-my-project-01', { account_id: '023e105f4ecef8ad9ca31a8372d0c353', + env: 'preview', }); }); diff --git a/tests/api-resources/pages/projects/projects.test.ts b/tests/api-resources/pages/projects/projects.test.ts index 4ef037a910..5381560131 100644 --- a/tests/api-resources/pages/projects/projects.test.ts +++ b/tests/api-resources/pages/projects/projects.test.ts @@ -53,7 +53,13 @@ describe('resource projects', () => { placement: { mode: 'smart' }, queue_producers: { QUEUE_PRODUCER_BINDING: { name: 'some-queue' } }, r2_buckets: { R2_BINDING: { name: 'some-bucket' } }, - services: { SERVICE_BINDING: { environment: 'production', service: 'example-worker' } }, + services: { + SERVICE_BINDING: { + entrypoint: 'MyHandler', + environment: 'production', + service: 'example-worker', + }, + }, vectorize_bindings: { VECTORIZE: { index_name: 'my_index' } }, }, production: { @@ -71,7 +77,13 @@ describe('resource projects', () => { placement: { mode: 'smart' }, queue_producers: { QUEUE_PRODUCER_BINDING: { name: 'some-queue' } }, r2_buckets: { R2_BINDING: { name: 'some-bucket' } }, - services: { SERVICE_BINDING: { environment: 'production', service: 'example-worker' } }, + services: { + SERVICE_BINDING: { + entrypoint: 'MyHandler', + environment: 'production', + service: 'example-worker', + }, + }, vectorize_bindings: { VECTORIZE: { index_name: 'my_index' } }, }, },