Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to collect log lines emitted in traced contexts in span logs #58

Open
LloydW93 opened this issue Jul 30, 2024 · 1 comment · May be fixed by #59
Open

Add option to collect log lines emitted in traced contexts in span logs #58

LloydW93 opened this issue Jul 30, 2024 · 1 comment · May be fixed by #59

Comments

@LloydW93
Copy link
Member

Example use case:

An HTTP service, for which some requests are sampled through distributed tracing, whilst its syslogs are sampled/rate limited in collection - so for a traced request with a failure, it's possible the log information from that error has been dropped, or if it is, exists in some separate system.

Instead, as foundations already provides both a logging and tracing module, the logging module could be configurable to additionally send log entries over to the tracing module. Unlike other drains and pipelines, this would not be heavily filtered and sampled - so the logs that are most useful for the requests we have traced information for are the ones we know we will have retained, right where we need to see them.

@inikulin
Copy link
Collaborator

inikulin commented Aug 5, 2024

Not sure I understand the motivation here.

syslogs are sampled/rate limited in collection

They are not, unless it's explicitly specified. Most of our services don't have rate limiting for logs.
If you want to not rate limit logs if there's active tracing span in scope then more likely most of the hot paths in the service have traces, so, effectively, you just disable rate limiting. So, I'm not sure there's any sense to have this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants