Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not including detail id in wrangler output from R2 event notifications #6671

Merged

Conversation

jkoe-cf
Copy link
Contributor

@jkoe-cf jkoe-cf commented Sep 10, 2024

What this PR solves / how to test

Updates the fields parsed and displayed in wrangler from the R2 Event Notification PUT payload from the Cloudflare API.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: covered by existing tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: unlikely to affect e2e flows—no user-facing change
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

@jkoe-cf jkoe-cf requested a review from a team as a code owner September 10, 2024 22:40
Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: db4b352

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 10, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-wrangler-6671

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6671/npm-package-wrangler-6671

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-wrangler-6671 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-create-cloudflare-6671 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-cloudflare-kv-asset-handler-6671
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-miniflare-6671
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-cloudflare-pages-shared-6671
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-cloudflare-vitest-pool-workers-6671
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-cloudflare-workers-editor-shared-6671
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10821498316/npm-package-cloudflare-workers-shared-6671

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.76.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.2
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally good, but could you fill in the PR template? In particular, this should have a changeset.

@@ -488,8 +488,7 @@ export async function getEventNotificationConfig(

/** Construct & transmit notification configuration to EWC.
*
* On success, receive HTTP 200 response with a body like:
* { event_notification_detail_id: string }
* On success, receive HTTP 200 response no body (originally was { event_notification_detail_id: string })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* On success, receive HTTP 200 response no body (originally was { event_notification_detail_id: string })
* On success, receive HTTP 200 response with no body

@lrapoport-cf lrapoport-cf added the caretaking Priority for caretaking label Sep 11, 2024
@jkoe-cf jkoe-cf force-pushed the jkoe/update-create-event-notification-config branch 3 times, most recently from 229a2f5 to 78a37bc Compare September 11, 2024 21:23
"wrangler": patch
---

feat: Update R2 Create Event Notification response
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
feat: Update R2 Create Event Notification response
fix: Update R2 Create Event Notification response

@jkoe-cf jkoe-cf force-pushed the jkoe/update-create-event-notification-config branch from 78a37bc to db4b352 Compare September 11, 2024 23:56
@penalosa
Copy link
Contributor

penalosa commented Sep 12, 2024

For posterity, we're merging this without passing status checks intentionally. It's repeatedly flaking on Windows fixtures and re-running isn't helping because it's on a fork and so Turbo caching isn't enabled. We're confident the failures are unrelated to these changes, and in any case will re-run the fixtures before releasing a version of Wrangler with this change. Approved by @lrapoport-cf

@penalosa penalosa merged commit 48eeff4 into cloudflare:main Sep 12, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caretaking Priority for caretaking
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants