Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve node_compat warning for v2 #6781

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

mikenomitch
Copy link
Contributor

@mikenomitch mikenomitch commented Sep 19, 2024

Note: This should not be merged until Sept 23, when nodejs_compat includes nodejs_compat_v2 functionality.

What this PR solves / how to test

Fixes #6759

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: text change
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because: minor text change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: minor text change

@mikenomitch mikenomitch requested a review from a team as a code owner September 19, 2024 21:15
Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: 5a6939e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 19, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-wrangler-6781

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6781/npm-package-wrangler-6781

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-wrangler-6781 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-create-cloudflare-6781 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-cloudflare-kv-asset-handler-6781
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-miniflare-6781
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-cloudflare-pages-shared-6781
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-cloudflare-vitest-pool-workers-6781
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-cloudflare-workers-editor-shared-6781
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11015577765/npm-package-cloudflare-workers-shared-6781

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.78.8 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.5
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need changeset but messaging 👍

packages/wrangler/src/deployment-bundle/node-compat.ts Outdated Show resolved Hide resolved
@mikenomitch mikenomitch force-pushed the mikenomitch/improve-node-compat-warning branch from 59888eb to 7e9acfa Compare September 24, 2024 03:38
@mikenomitch mikenomitch requested a review from a team as a code owner September 24, 2024 03:38
@petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin force-pushed the mikenomitch/improve-node-compat-warning branch from 959f645 to 5a6939e Compare September 24, 2024 14:10
@petebacondarwin
Copy link
Contributor

Pushed a fixup commit

@edmundhung edmundhung merged commit 0792fa0 into main Sep 24, 2024
22 checks passed
@edmundhung edmundhung deleted the mikenomitch/improve-node-compat-warning branch September 24, 2024 14:20
@irvinebroque
Copy link
Contributor

Thanks Edmund!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Improve node_compat = true warning
4 participants