Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wrangler): Validate routes on config file changes #6819

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Sep 24, 2024

What this PR solves / how to test

Fixes WC-2757

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not documented

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner September 24, 2024 20:09
Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 4e560f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 24, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11051135465/npm-package-wrangler-6819

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6819/npm-package-wrangler-6819

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11051135465/npm-package-wrangler-6819 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11051135465/npm-package-create-cloudflare-6819 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11051135465/npm-package-cloudflare-kv-asset-handler-6819
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11051135465/npm-package-miniflare-6819
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11051135465/npm-package-cloudflare-pages-shared-6819
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11051135465/npm-package-cloudflare-vitest-pool-workers-6819
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11051135465/npm-package-cloudflare-workers-editor-shared-6819
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11051135465/npm-package-cloudflare-workers-shared-6819

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.78.10 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240925.0
workerd 1.20240925.0 1.20240925.0
workerd --version 1.20240925.0 2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu
Copy link
Contributor Author

CarmenPopoviciu commented Sep 24, 2024

@emily-shen I'll leave this in your hands to shepherd across the finish line ♥️ . The only thing left to figure out here are tests. Watch mode tests live here, though I'm not 100% sure if this should be an e2e test, since technically we'd want to test stdout for errors. On the other hand, it doesn't seem like unit tests support smth like "wait until changes are detected then make assertions". So there's some figuring out to do here.

wrangler dev --x-dev-env works out of the box, so what I have in here is literally the only change needed ^.^

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Sep 25, 2024
@RamIdeas RamIdeas merged commit 7ede181 into main Sep 26, 2024
24 checks passed
@RamIdeas RamIdeas deleted the carmen/validate-routes branch September 26, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants