Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-cloudflare): ignore network errors during telemetry collection #6836

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Sep 26, 2024

What this PR solves / how to test

Fixes N/A

This PR prevents the create-cloudflare cli from crashing by silently ignoring network errors during telemetry collection, (e.g. network error because of certificate issues)

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no impacts
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no feature change

@edmundhung edmundhung requested review from a team as code owners September 26, 2024 13:17
Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: 3845068

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 26, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11071618459/npm-package-wrangler-6836

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6836/npm-package-wrangler-6836

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11071618459/npm-package-wrangler-6836 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11071618459/npm-package-create-cloudflare-6836 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11071618459/npm-package-cloudflare-kv-asset-handler-6836
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11071618459/npm-package-miniflare-6836
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11071618459/npm-package-cloudflare-pages-shared-6836
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11071618459/npm-package-cloudflare-vitest-pool-workers-6836
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11071618459/npm-package-cloudflare-workers-editor-shared-6836
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11071618459/npm-package-cloudflare-workers-shared-6836

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.78.11 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240925.0
workerd 1.20240925.0 1.20240925.0
workerd --version 1.20240925.0 2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung force-pushed the edmundhung/c3-telemetry-ignore-network-errors branch from 2883d10 to 3845068 Compare September 27, 2024 13:32
@RamIdeas RamIdeas merged commit a67cdbf into main Sep 27, 2024
32 checks passed
@RamIdeas RamIdeas deleted the edmundhung/c3-telemetry-ignore-network-errors branch September 27, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants