Fix Health Monitor JSON plugin + add error logging #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Health Monitor JSON plugin was silently failing with the following error: ``` uninitialized constant Async::IO::Stream ``` This was due to a change in the async-io gem where neither async/io nor async/io/stream are automatically required anymore when the gem is installed. In addition to adding the require, logging has been added when an internal Ruby exception occurs while running the custom JSON plugin scripts. This should make it easier to diagnose problems in the future. Logging has explicitly not been added when the custom plugin script returns a non-zero exit code, maintaining just the existing "Restarted process" log message..
aramprice
approved these changes
Jun 14, 2024
selzoc
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Health Monitor JSON plugin was silently failing with the following error:
This was due to a change in the async-io gem where neither async/io nor async/io/stream are automatically required anymore when the gem is installed.
In addition to adding the require, logging has been added when an internal Ruby exception occurs while running the custom JSON plugin scripts. This should make it easier to diagnose problems in the future. Logging has explicitly not been added when the custom plugin script returns a non-zero exit code, maintaining just the existing "Restarted process" log message..
Fixes #2528