-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the tag
on the ubuntu docker image
#2539
Conversation
These tags are outdated, xenial and trusty, are out of support. Implicity use `latest`, the tasks are using common commands like `cp` and `mkdir` [#187900893] Signed-off-by: Ming Xiao <ming.xiao@broadcom.com>
@@ -5,7 +5,6 @@ image_resource: | |||
type: docker-image | |||
source: | |||
repository: ubuntu | |||
tag: "14.04" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will always pull the latest version of ubuntu
, noble
atm. Is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the ubuntu docker image used in other task use latest: https://github.com/cloudfoundry/bosh/blob/main/ci/pipeline.yml#L1427
The bash script this file runs only uses cp
and mkdir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the 14.04
line is trusty
which is older than the now out of support xenial
@@ -5,7 +5,6 @@ image_resource: | |||
type: docker-image | |||
source: | |||
repository: ubuntu | |||
tag: xenial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will always pull the latest version of ubuntu
, noble
atm. Is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the ubuntu docker image used in other task use latest: https://github.com/cloudfoundry/bosh/blob/main/ci/pipeline.yml#L1427
The bash script this file runs only uses cp
and mkdir
thinking it's probably fine to float on ubuntu
|
These tags are outdated, xenial and trusty, are out of support. Implicity use
latest
, the tasks are using common commands likecp
andmkdir
[#187900893]
What is this change about?
remove the
tag
on the ubuntu docker imageThese tags are outdated, xenial and trusty, are out of support. Implicity use
latest
, the tasks are using common commands likecp
andmkdir
Please provide contextual information.
Include any links to other PRs, stories, slack discussions, etc... that will help establish context.
What tests have you run against this PR?
None, these are pipeline changes.
How should this change be described in bosh release notes?
There is no impact on release notes, these are pipeline changes
Does this PR introduce a breaking change?
No
Tag your pair, your PM, and/or team!
@rajathagasthya