Replace netaddr with ipaddr #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramprice
force-pushed
the
replace-netaddr
branch
4 times, most recently
from
105e4e8
to
07fbd70
Compare
... rather than relying on an include in `src/bosh-director/lib/bosh/director.rb`
The internal class IpAddrOrCidr uses the ruby stdlib IPAddr class
internally.
Note that IPAddr is used in specs and cloud/dummy{,_v2}.rb code since
these bits of code my not have access to `Bosh::Director` code at
runtime.
Signed-off-by: Ming Xiao <ming.xiao@broadcom.com>
aramprice
force-pushed
the
replace-netaddr
branch
from
07fbd70
to
68ce7c2
Compare
aramprice
requested review from
a team,
ystros and
mvach
and removed request for
a team
xtreme-nitin-ravindran
approved these changes
Aug 7, 2024
ystros
approved these changes
Aug 9, 2024
| @@ -50,7 +50,7 @@ def allocate_dynamic_ip(reservation, subnet) | |||
| retry | |||
| end | |||
|
|
|||
| @logger.debug("Allocated dynamic IP '#{ip_address.ip}' for #{reservation.network.name}") | |||
There was a problem hiding this comment.
Mostly commenting since it wasn't immediately intuitive to me: IpAddr#to_s returns only the IP address portion provided, even for CIDRs, and thus is equivalent to the old NetAddr#ip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Replace vendored
NetAddrgem dev version and replace it with the ruby standardIPAddrgemWhat tests have you run against this PR?
How should this change be described in bosh release notes?
n/a
Does this PR introduce a breaking change?
No.