Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: reformat dockerfile and bump git-crypt #148

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Fix: reformat dockerfile and bump git-crypt #148

merged 2 commits into from
Feb 22, 2023

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Feb 21, 2023

What is this change about?

  • Write each complicated RUN step as a mini bash script. I think it's clearer to read.
  • Bump git-crypt to latest.
  • Install binaries where possible.

Please provide contextual information.

None

Please check all that apply for this PR:

  • introduces a new task
  • changes an existing task
  • changes the Dockerfile
  • introduces a breaking change (other users will need to make manual changes when this is released)

Did you update the README as appropriate for this change?

  • YES
  • N/A

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

None

* Uses `set -eux` and semicolons instead of joining with `&&`.
* No longer places bbl assets in `/var/repos/bosh-bootloader`, which I
  don't think are needed.
* Installs cf CLI binary instead of using the debian installer.
@ctlong ctlong marked this pull request as ready for review February 21, 2023 21:47
@ctlong ctlong requested a review from a team February 21, 2023 21:49
@ctlong ctlong merged commit 8b597ad into main Feb 22, 2023
@ctlong ctlong deleted the fix/dockerfile branch February 22, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants